fix(secp256k1): support libsecp256k1 v0.7 seckey symbol rename#91
Open
m0wer wants to merge 1 commit into
Open
Conversation
libsecp256k1 v0.7.0 renamed secp256k1_ec_privkey_tweak_add and secp256k1_ec_privkey_negate to their secp256k1_ec_seckey_* counterparts. Loading the modern library against the old code path failed with an AttributeError on import. Probe for the modern symbol first and fall back to the legacy one, then expose the resolved function under both names on the library handle so downstream code (including bitcointx.core.key) keeps working regardless of which spelling it uses. Add a unit-test module that exercises _add_function_definitions against a fake CDLL exposing legacy-only, modern-only, or both symbol sets, so the compatibility shim is covered without requiring a real libsecp256k1. Closes Simplexum#88.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libsecp256k1 v0.7.0 renamed secp256k1_ec_privkey_tweak_add and secp256k1_ec_privkey_negate to their secp256k1_ec_seckey_* counterparts. Loading the modern library against the old code path failed with an AttributeError on import.
Probe for the modern symbol first and fall back to the legacy one, then expose the resolved function under both names on the library handle so downstream code (including bitcointx.core.key) keeps working regardless of which spelling it uses.
Add a unit-test module that exercises _add_function_definitions against a fake CDLL exposing legacy-only, modern-only, or both symbol sets, so the compatibility shim is covered without requiring a real libsecp256k1.
Closes #88.